fix(ui): prevent data loss in copy-to-locale with drafts#16073
Merged
fix(ui): prevent data loss in copy-to-locale with drafts#16073
Conversation
- Add draft:true to findByID/findGlobal calls to support draft-only documents - Add draft:true to update/updateGlobal calls to prevent overwriting published content when source has both published and draft versions
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
paulpopus
approved these changes
Mar 30, 2026
Contributor
|
🚀 This is included in version v3.81.0 |
milamer
pushed a commit
to milamer/payload
that referenced
this pull request
Apr 20, 2026
…16073) ## Summary Fixes two related bugs in copyDataFromLocale that cause data loss when using the "Copy to Locale" feature with drafts/autosave enabled: 1. 500 error with draft-only documents: When a document only exists as a draft (never published), copy-to-locale failed with "Error fetching data from locale" because findByID without draft: true can't find draft-only documents. 2. Published content overwritten: When the source locale has both published and draft versions with different content, copying to another locale would overwrite the source locale's published content with the draft content. ### Root Cause The copyDataFromLocale function was: - Fetching documents without draft: true, failing on draft-only docs - Calling update() without draft: true, which creates a new published version that snapshots all locales - but using draft data instead of published data for the source locale ### Fix Added draft: true to: - All findByID/findGlobal calls (4 places) - allows finding draft-only documents - All update/updateGlobal calls (2 places) - creates draft instead of published, preserving existing published content ### Behavior Change Copy-to-locale now creates a draft in the target locale instead of immediately publishing. This is arguably better UX since users can review translations before publishing. ## Test Plan - Added integration tests for copy-to-locale with autosave/drafts - Added integration test for draft-only documents - Added integration test verifying published content isn't overwritten - Added e2e test for full UI flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two related bugs in copyDataFromLocale that cause data loss when using the "Copy to Locale" feature with drafts/autosave enabled:
Root Cause
The copyDataFromLocale function was:
Fix
Added draft: true to:
Behavior Change
Copy-to-locale now creates a draft in the target locale instead of immediately publishing. This is arguably better UX since users can review translations before publishing.
Test Plan