Add config saving to payjoin-cli #947
Open
+94
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zealsham
changed the title
Collaborator
Pull Request Test Coverage Report for Build 17533798681Details
💛 - Coveralls |
benalleng
reviewed
Aug 11, 2025
benalleng
reviewed
Aug 12, 2025
benalleng
reviewed
Aug 12, 2025
zealsham
force-pushed
the
add-saving-config
branch
from
835f837 to
e6760ab
Compare
zealsham
changed the title
Closed
zealsham
force-pushed
the
add-saving-config
branch
from
e6760ab to
aaecfaa
Compare
zealsham
force-pushed
the
add-saving-config
branch
from
e3cf58d to
aed6dcf
Compare
zealsham
commented
Sep 3, 2025
zealsham
force-pushed
the
add-saving-config
branch
from
832d071 to
a1095b0
Compare
benalleng
requested changes
Sep 4, 2025
Collaborator
benalleng
left a comment
benalleng
left a comment
There was a problem hiding this comment.
Ok, so there have been some big changes since my first review after #957 I think it is safe to now use the latest toml version now 0.9.5 https://crates.io/crates/toml/0.9.5
As well I found that testing it was difficult to grok how it was supposed to be used perhaps a brief section in the payjoin-cli configuration readme section about this option would be helpful
benalleng
reviewed
Sep 4, 2025
This Pr adds the ability to save config files for V2 to payjoin-cli . This is introduced via a set-config commandline arg that only works for v2 and when the right set of supporting args is present . fix poor merge conflict resolve update payjoin-cli docs for --set-config
zealsham
force-pushed
the
add-saving-config
branch
from
a1095b0 to
8d94c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pr adds the ability to save commandline arguement relevant to the config file into a config.toml file in the present directory if anyone exist or into the default xdg-compliant directory .
This pr close #896