Skip to content

Conversation

@mehmetefeumit
Copy link
Contributor

@mehmetefeumit mehmetefeumit commented Dec 23, 2025

Pull Request Checklist

Please confirm the following before requesting review:

Overview

This PR contains a couple of changes related to the higher-level documentation in the repository:

  1. Refine the existing repo-level README with up-to-date list of crates, concise information, etc.
  2. Refine the lib.rs of the payjoin crate so that rust docs are tidier and more concise.
  3. While I am at it, updates some Receiver documentation.
  4. Finally, adds a Discord server badge to the repository README.

Closes #1216

@mehmetefeumit mehmetefeumit force-pushed the readme-rustdoc branch 2 times, most recently from 38e7626 to 222518b Compare December 23, 2025 05:25
@coveralls
Copy link
Collaborator

coveralls commented Dec 23, 2025

Pull Request Test Coverage Report for Build 20638228938

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.903%

Totals Coverage Status
Change from base Build 20617301558: 0.0%
Covered Lines: 9669
Relevant Lines: 11663

💛 - Coveralls

@DanGould DanGould self-requested a review December 24, 2025 06:13
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic much needed changes to our docs. Where I made suggestions about specific wording, I tried to offer a suggestion that you can accept by simply clicking. My main concern is the addition of a payjoin/readme including examples which can't be checked against the compiler. I think it's more rusty to leave the top-level readme as the payjoin crate readme, as a sort of entrypoint into the project. Then, once someone opens docs.rs they can see the payjoin module's lib.rs rustdocs that are checked by the compiler for examples and details.

Once those are checked I think this is ready to go.

### [`ohttp-relay`](https://github.com/payjoin/rust-payjoin/tree/master/ohttp-relay)

### `payjoin-ffi`
A Rust implementation of an Oblivious HTTP (OHTTP) relay resource.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth mentioning high-level bip77 specific changes here and definitely in the ohttp-relay readme. TODO

@mehmetefeumit
Copy link
Contributor Author

@DanGould Thanks for all the feedback. I addressed all of them.

After seeing the rust-bitcoin and rust-lightning references you shared, I decided to keep the lib.rs content after the change minimal, with a very short summary of the crate and the features available. Otherwise, all of the other changes are going to be similar to what you first reviewed, plus the changes you recommended.

@mehmetefeumit mehmetefeumit requested a review from DanGould January 1, 2026 12:12
@mehmetefeumit mehmetefeumit changed the title Refine READMEs and Mirror in Rustdocs Refine Repo README and payjoin lib.rs Jan 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README and rustdocs mirror

3 participants