-
Notifications
You must be signed in to change notification settings - Fork 77
Save max fee rate in receiver session context #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save max fee rate in receiver session context #1033
Conversation
Pull Request Test Coverage Report for Build 17436370745Details
💛 - Coveralls |
|
Thanks @arminsabouri |
|
"Co-authored-by" is the syntax you want in a commit message |
4b468f8 to
c1c79df
Compare
|
Dart tests are problematic |
spacebear21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c1c79df.
I think the spooky uniffi-dart error in CI is due to the return type in with_max_fee_rate containing bitcoin_ffi::error::FeeRateError.
c1c79df to
3f0c442
Compare
The reference implementation currently overrides the original max fee rate preference when resuming a session. This commit pins the max fee rate preference to the session by persisting it in the session context. When applying fees, if the applications’s fee rate preference has changed, the updated preference takes precedence. Co-authored-by: Johnosezele <johnosezele@gmail.com>
3f0c442 to
e53b00b
Compare
Ended up wrapping |
spacebear21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, opened an issue here to track the underlying uniffi-dart issue.
The reference implementation currently overrides the original max fee rate preference when resuming a session. This commit pins the max fee rate preference to the session by persisting it in the session context. When applying fees, if the applications’s fee rate preference has changed, the updated preference takes precedence.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.
--
Closes http://github.com/payjoin/rust-payjoin/issues/897
Changes were picked off #934
cc @Johnosezele