Remove apt commands from bindings generate script #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually use apt in this script. And its possible apt is not the prefered package manager of the distro.
Collaborator
Author
|
Wooo PR number 1000! |
2 tasks
Collaborator
Pull Request Test Coverage Report for Build 17275565469Details
💛 - Coveralls |
DanGould
approved these changes
Aug 27, 2025
Collaborator
|
We came across this in #997, which should simplify the script... It's not just weird to run sudo it's also that apt is not portable. |
Collaborator
|
Ahh makes sense that this shouldn't have been in this script specifically with os variations, I pulled it out from the workflow file here 363d2b5#diff-092659a9bd0068791326fb1d08f005532e5aeb983b999a7bd32c51deee0a71d5L42-L43 should we put it back there since we are specifically working with an |
benalleng
added a commit
to benalleng/rust-payjoin
that referenced
this pull request
Aug 27, 2025
I moved this code incorrectly in payjoin#989 to a general binding build script but others not using a debian based system immediately ran into problems running this apt based package manager on their machine. It was removed in payjoin#1000 from the binding script but This probably should just be returned to the workflow it was originally.
benalleng
added a commit
to benalleng/rust-payjoin
that referenced
this pull request
Aug 27, 2025
I moved this code incorrectly in payjoin#989 to a general binding build script but others not using a debian based system immediately ran into problems running this apt based package manager on their machine. It was removed in payjoin#1000 from the binding script but This probably should just be returned to the workflow it was originally.
DanGould
pushed a commit
to DanGould/rust-payjoin
that referenced
this pull request
Aug 28, 2025
I moved this code incorrectly in payjoin#989 to a general binding build script but others not using a debian based system immediately ran into problems running this apt based package manager on their machine. It was removed in payjoin#1000 from the binding script but This probably should just be returned to the workflow it was originally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually use apt in this script. And its possible apt is not the prefered package manager of the distro.
Pull Request Checklist
Please confirm the following before requesting review: