-
Notifications
You must be signed in to change notification settings - Fork 13
Add SEO plugin #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add SEO plugin #32
Conversation
|
Does this not require a change to the package.json? I fought with this a bit last night to no avail. Despite the appropriate headers I noticed it still was not working in the debug pages. See https://github.com/payjoin/payjoindevkit.org/tree/open-graph |
|
Yes you are right, technically it says it needs to be a dev dependency. https://github.com/lorisleiva/vuepress-plugin-seo What are you referring to when you say "debug pages"? Happy to try to take a look. |
|
https://developers.facebook.com/tools/debug/ thanks for the help! Linkedin and twitter also have similar debuggers. |
|
I think it'd need to be a full dep and not a dev dep to be used in production as well. |
|
Ah gotcha. I don't have a facebook to login to, and I had tried with twitter's debugger earlier but it wouldn't let me use a localhost url.
When you tried it in the debug pages did you force a refetch by adding some dummy query params? Otherwise there could be issues with the tags being cached.
This seems weird. Why would dev dep work for local build but not production build? I've never heard of this sort of thing before but I am also completely new to vuepress. |
8461506 to
16f952d
Compare
|
ok! I made a lot of progress with some caveats. first it looks like commit b788b7a was what originally broke SEO tags because the plugins in the spiral theme were being overridden, and the spiral theme is what had the so I have reverted those changes and added the card.png file that you were using in the the caveat is that removing the plugin section will change the blog link structure. currently the blog links look like:
but if this gets merged it will instead look like
that was the main affect I could identify from this change, however I am extremely unfamiliar with vuepress so there may be other side effects that I haven't been able to identify. let me what you think :) |
Add SEO plugin so that links in twitter and other social media sites look nice.
Here are the before and after open graph values from testing locally

