Skip to content

Conversation

@xstoicunicornx
Copy link
Contributor

Add SEO plugin so that links in twitter and other social media sites look nice.

Here are the before and after open graph values from testing locally
image
image

@DanGould
Copy link
Contributor

Does this not require a change to the package.json? I fought with this a bit last night to no avail. Despite the appropriate headers I noticed it still was not working in the debug pages. See https://github.com/payjoin/payjoindevkit.org/tree/open-graph

@xstoicunicornx
Copy link
Contributor Author

Yes you are right, technically it says it needs to be a dev dependency.

https://github.com/lorisleiva/vuepress-plugin-seo

What are you referring to when you say "debug pages"? Happy to try to take a look.

@DanGould
Copy link
Contributor

https://developers.facebook.com/tools/debug/ thanks for the help! Linkedin and twitter also have similar debuggers.

@DanGould
Copy link
Contributor

I think it'd need to be a full dep and not a dev dep to be used in production as well.

@xstoicunicornx
Copy link
Contributor Author

xstoicunicornx commented Sep 24, 2025

Ah gotcha. I don't have a facebook to login to, and I had tried with twitter's debugger earlier but it wouldn't let me use a localhost url.

Despite the appropriate headers I noticed it still was not working in the debug pages

When you tried it in the debug pages did you force a refetch by adding some dummy query params? Otherwise there could be issues with the tags being cached.

I think it'd need to be a full dep and not a dev dep to be used in production as well.

This seems weird. Why would dev dep work for local build but not production build? I've never heard of this sort of thing before but I am also completely new to vuepress.

@xstoicunicornx
Copy link
Contributor Author

xstoicunicornx commented Oct 3, 2025

ok! I made a lot of progress with some caveats.

first it looks like commit b788b7a was what originally broke SEO tags because the plugins in the spiral theme were being overridden, and the spiral theme is what had the vuepress-plugin-seo config to return the right meta tags.

so I have reverted those changes and added the card.png file that you were using in the open-graph branch you were working on. you can see it working at my github page. I tested it in a few different debug tools and seems to be working everywhere. (note, there is an extra commit in my xstoicunicornx/xstoicunicorn.github.io repo to change the baseurl but the second to last commit is 16f952d same as this branch)

the caveat is that removing the plugin section will change the blog link structure. currently the blog links look like:

https://payjoindevkit.org/2025/03/18/the-evolution-of-payjoin/

but if this gets merged it will instead look like

https://payjoindevkit.org/blog/the-evolution-of-payjoin/

that was the main affect I could identify from this change, however I am extremely unfamiliar with vuepress so there may be other side effects that I haven't been able to identify.

let me what you think :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants