Skip to content

fix(ContextSubMenuItem): Remove truncation of context submenu items #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenny-s51 merged 1 commit into from
Sep 25, 2025
Merged

fix(ContextSubMenuItem): Remove truncation of context submenu items #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/demo-app-ts/src/demos/topologyPackageDemo/demoComponentFactory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ import {
EditableDragOperationType,
GraphElementProps,
isEdge,
Model
Model,
ContextSubMenuItem
} from '@patternfly/react-topology';
import CustomPathNode from '../../components/CustomPathNode';
import CustomPolygonNode from '../../components/CustomPolygonNode';
Expand Down Expand Up @@ -99,8 +100,16 @@ const contextMenuItem = (label: string, i: number): React.ReactElement => {
if (label === '-') {
return <ContextMenuSeparator component="li" key={`separator:${i.toString()}`} />;
}
if (label === 'Second') {
return (
<ContextSubMenuItem label={label} key={label}>
<ContextMenuItem onClick={() => alert(`Selected: ${label} 1`)}>{`${label} subitem number 1`}</ContextMenuItem>
<ContextMenuItem onClick={() => alert(`Selected: ${label} 2`)}>{`${label} subitem number 2`}</ContextMenuItem>
<ContextMenuItem onClick={() => alert(`Selected: ${label} 3`)}>{`${label} subitem number 3`}</ContextMenuItem>
</ContextSubMenuItem>
);
}
return (
// eslint-disable-next-line no-alert
<ContextMenuItem key={label} onClick={() => alert(`Selected: ${label}`)}>
{label}
</ContextMenuItem>
Expand All @@ -117,7 +126,7 @@ const demoComponentFactory: ComponentFactory = (
): React.ComponentType<{ element: GraphElement }> | undefined => {
if (kind === ModelKind.graph) {
return withDndDrop(graphDropTargetSpec([NODE_DRAG_TYPE]))(
withPanZoom()(withAreaSelection(['ctrlKey', 'shiftKey'])(GraphComponent))
withPanZoom()(withAreaSelection(['ctrlKey', 'shiftKey'])(withContextMenu(() => defaultMenu)(GraphComponent)))
);
}
switch (type) {
Expand Down
1 change: 1 addition & 0 deletions packages/module/src/components/contextmenu/ContextSubMenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ const ContextSubMenuItem: React.FunctionComponent<ContextSubMenuItemProps> = ({
<AngleRightIcon className={css(topologyStyles.topologyContextSubMenuArrow)} />
</DropdownItem>
<Popper
className={css(topologyStyles.topologyContextSubMenuContainer)}
open={open}
placement="right-start"
closeOnEsc
Expand Down
4 changes: 4 additions & 0 deletions packages/module/src/css/topology-components.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,10 @@
padding-right: var(--pf-t--global--spacer--lg) !important;
}

.pf-topology-context-sub-menu__container .pf-v6-c-menu__list-item {
min-width: auto;
}

.pf-topology-context-sub-menu__arrow {
position: absolute;
right: var(--pf-t--global--spacer--xs);
Expand Down