feat: Enable DefaultEdge as drop target #278
Conversation
There was a problem hiding this comment.
Tested the DefaultEdge drag and drop functionality locally - looks great and works as expected.
Just one thing I noticed while testing - when toggling the "Edge options" from the dropdown menu in Topology Package, and dragging a node over a styled edge, the UI throws an error and a blank screen.
It looks like a recent update is resulting in an undefined value in DemoEdge.tsx.
| .pf-topology__edge__link.pf-m-drop-target { | ||
| stroke-dasharray: 2; | ||
| stroke-dashoffset: 2; | ||
| stroke: var(--pf-t--global--border--color--brand--default); |
There was a problem hiding this comment.
Can we swap this token please:
stroke: var(--pf-t--global--border--color--hover)
There was a problem hiding this comment.
Can we swap this token please: stroke: var(--pf-t--global--border--color--hover)
@andrew-ronaldson Done:
jeff-phillips-18
force-pushed
the
droppable-edges
branch
2 times, most recently
from
7e64cd9 to
86b00c0
Compare
jeff-phillips-18
force-pushed
the
droppable-edges
branch
from
86b00c0 to
b9dd764
Compare
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Thank you @jeff-phillips-18 - Retested in demo-app, drag and drop works as expected when dragging a node onto a styled edge. LGTM.
|
@andrew-ronaldson Are you ok with the update above? |
|
🎉 This PR is included in version 6.2.0-prerelease.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 participants
What
Closes Topology - Enable DefaultEdge as drop target
Description
Adds parameters and styles to
DefaultEdgefor drop target indication.Adds
edgeDropTargetSpecUpdates the demo app to demo the new feature
Type of change
Screen shots / Gifs for design review