Skip to content

fix: allow user override of internal ThProps #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kmcfaul wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow user override of internal ThProps #596

kmcfaul wants to merge 1 commit into from

Conversation

@kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jan 29, 2026 •
edited
Loading

Closes #576.

Allows user set modifier, className, style props which were being ignored.
Cleans up some prop descriptions for resizable props.

I was unable to reproduce the issue where width props were being ignored, both the th props:width and resizableProps:width function normally.

@patternfly-build
Copy link

patternfly-build commented Jan 29, 2026 •
edited
Loading

Preview: https://react-data-view-pr-data-view-596.surge.sh

A11y report: https://react-data-view-pr-data-view-596-a11y.surge.sh

@karelhala karelhala self-requested a review January 30, 2026 15:12
@nicolethoen nicolethoen self-requested a review January 30, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karelhala karelhala Awaiting requested review from karelhala

@nicolethoen nicolethoen Awaiting requested review from nicolethoen

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Column headers always truncate

2 participants

@kmcfaul @patternfly-build