-
Notifications
You must be signed in to change notification settings - Fork 376
feat(react-icons): update to create static SVGs #12154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://pf-react-pr-12154.surge.sh A11y report: https://pf-react-pr-12154-a11y.surge.sh |
kmcfaul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great! I don't think the added dir to the icons build should make too much of a difference because it should tree shake out unused icons if I understand that process correctly (or users would import directly from the dist).
dlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the size is okay since it's 11mb and people can always just import what they need.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
fixes #12153
A couple of thoughts