Skip to content

fix(Compass): wrap in DrawerContentBody when drawer is passed #12127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatblindgeye merged 2 commits into from
Nov 10, 2025
Merged

fix(Compass): wrap in DrawerContentBody when drawer is passed #12127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a18ea9e
fix(Compass): wrap in DrawerContentBody when drawer is passed
kmcfaul Nov 6, 2025
609bba6
update snap
kmcfaul Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/react-core/src/components/Compass/Compass.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Drawer, DrawerContent, DrawerProps } from '../Drawer';
import { Drawer, DrawerContent, DrawerContentBody, DrawerProps } from '../Drawer';
import styles from '@patternfly/react-styles/css/components/Compass/compass';
import { css } from '@patternfly/react-styles';

Expand Down Expand Up @@ -96,7 +96,9 @@ export const Compass: React.FunctionComponent<CompassProps> = ({
if (hasDrawer) {
return (
<Drawer {...drawerProps}>
<DrawerContent panelContent={drawerContent}>{compassContent}</DrawerContent>
<DrawerContent panelContent={drawerContent}>
<DrawerContentBody>{compassContent}</DrawerContentBody>
</DrawerContent>
</Drawer>
);
}
Expand Down
60 changes: 32 additions & 28 deletions packages/react-core/src/components/Compass/__tests__/__snapshots__/Compass.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,41 +56,45 @@ exports[`Matches the snapshot with drawer 1`] = `
class="pf-v6-c-drawer__content"
>
<div
class="pf-v6-c-compass"
class="pf-v6-c-drawer__body"
>
<div
class="pf-v6-c-compass__header pf-m-expanded"
class="pf-v6-c-compass"
>
<div>
Header
<div
class="pf-v6-c-compass__header pf-m-expanded"
>
<div>
Header
</div>
</div>
</div>
<div
class="pf-v6-c-compass__sidebar pf-m-start pf-m-expanded"
>
<div>
Sidebar start
<div
class="pf-v6-c-compass__sidebar pf-m-start pf-m-expanded"
>
<div>
Sidebar start
</div>
</div>
</div>
<div
class="pf-v6-c-compass__main"
>
<div>
Main content
<div
class="pf-v6-c-compass__main"
>
<div>
Main content
</div>
</div>
</div>
<div
class="pf-v6-c-compass__sidebar pf-m-end pf-m-expanded"
>
<div>
Sidebar end
<div
class="pf-v6-c-compass__sidebar pf-m-end pf-m-expanded"
>
<div>
Sidebar end
</div>
</div>
</div>
<div
class="pf-v6-c-compass__footer pf-m-expanded"
>
<div>
Footer
<div
class="pf-v6-c-compass__footer pf-m-expanded"
>
<div>
Footer
</div>
</div>
</div>
</div>
Expand Down
11 changes: 10 additions & 1 deletion packages/react-core/src/components/Compass/examples/Compass.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,16 @@ id: Compass
cssPrefix: pf-v6-c-compass
section: components
beta: true
propComponents: ['Compass', 'CompassHeader', 'CompassContent', 'CompassHero', 'CompassMainHeader', 'CompassPanel']
propComponents:
[
'Compass',
'CompassHeader',
'CompassContent',
'CompassHero',
'CompassMainHeader',
'CompassPanel',
'CompassMessageBar'
]
---

import './compass.css';
Expand Down
Loading