feat(Drawer): Add pill version #12091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Collaborator
|
Preview: https://pf-react-pr-12091.surge.sh A11y report: https://pf-react-pr-12091-a11y.surge.sh |
kmcfaul
reviewed
Oct 27, 2025
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
react implementation looks good, just need to reverify when the styles are updated!
thatblindgeye
requested changes
Oct 27, 2025
packages/react-core/src/components/Drawer/__tests__/Drawer.test.tsx
Outdated
Show resolved
Hide resolved
Contributor
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
lgtm, will wait for the styles to be pulled in
Contributor
|
The drawer PR has been merged - patternfly/patternfly#7945 and is in |
thatblindgeye
approved these changes
Oct 31, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled in classes/added two demos to reflect @mcoker's work. Kept demo format for React matching React since it differs slightly but made sure we had both examples he added - inline and basic pill.
What: Closes #12087
Additional issues: