Skip to content

feat(ExpandableSection): added aria labeling #12071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rebeccaalpert merged 1 commit into from
Oct 22, 2025
Merged

feat(ExpandableSection): added aria labeling #12071

rebeccaalpert merged 1 commit into from
Oct 22, 2025

Conversation

@thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Oct 17, 2025

What: Closes #12028

Additional issues:

@patternfly-build
Copy link
Collaborator

patternfly-build commented Oct 17, 2025 •
edited
Loading

Preview: https://pf-react-pr-12071.surge.sh

A11y report: https://pf-react-pr-12071-a11y.surge.sh

rebeccaalpert
rebeccaalpert approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine! 💃

@rebeccaalpert rebeccaalpert merged commit 88ed152 into patternfly:main Oct 22, 2025
13 checks passed
@patternfly-build
Copy link
Collaborator

patternfly-build commented Oct 22, 2025

Your changes have been released in:

  • @patternfly/react-code-editor@6.4.1-prerelease.2
  • @patternfly/react-core@6.4.1-prerelease.2
  • @patternfly/react-docs@7.4.1-prerelease.2
  • @patternfly/react-drag-drop@6.4.1-prerelease.2
  • demo-app-ts@6.0.0-prerelease.168
  • @patternfly/react-table@6.4.1-prerelease.2
  • @patternfly/react-templates@6.4.1-prerelease.2

Thanks for your contribution! 🎉

@dgdavid dgdavid mentioned this pull request Oct 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

+1 more reviewer

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ExpandableSectionToggle - allow adding aria-label to internal button

4 participants

@thatblindgeye @patternfly-build @rebeccaalpert @wise-king-sullyman