Skip to content

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Oct 1, 2025

What: Closes #11938

Have not tested this against OCP but this fixes the core issue where the drawer panel content still takes up width even when closed.

After this PR, the panel content is still "display"ed but now takes up width 0.

We cannot use display: none here as that breaks the drawer opening animation

Additional issues:

@logonoff logonoff force-pushed the 11938-drawerpanelcontent branch from ec1b119 to 7354e16 Compare October 1, 2025 13:47
@rebeccaalpert
Copy link
Member

It looks like the drawerresize.spec.ts integration test is failing - would you mind taking a look?

@logonoff logonoff force-pushed the 11938-drawerpanelcontent branch from 7354e16 to 29aa1e5 Compare October 30, 2025 16:03
@logonoff logonoff changed the title fix(DrawerPanelContent): collapse space when drawer collapsed fix(DrawerPanelContent): add inert when drawer is closd Oct 30, 2025
@logonoff logonoff changed the title fix(DrawerPanelContent): add inert when drawer is closd fix(DrawerPanelContent): add inert when drawer is closed Oct 30, 2025
@patternfly-build
Copy link
Collaborator

patternfly-build commented Oct 30, 2025

@logonoff
Copy link
Member Author

@mcoker, I've updated the PR to just add the inert attribute when the drawer is closed.

It's unclear to me whether this will fix the issue I was having in OCP without running the end to end tests in an updated version of PatternFly. However, as you mentioned, we should have this attribute anyway so I think it's worth adding.

We can close the linked issue upon merging, and I'll reopen the issue if the problem continues to happen.

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM testing the examples/demos!

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we try adding a couple tests, one to check that inert is applied when isExpanded from the DrawerContext is false, and one to check that inert isn't applied when the isExpanded context is true?

@logonoff logonoff force-pushed the 11938-drawerpanelcontent branch from 29aa1e5 to 4113ad9 Compare December 11, 2025 14:15
@thatblindgeye thatblindgeye merged commit 8928745 into patternfly:main Dec 11, 2025
13 checks passed
@logonoff logonoff deleted the 11938-drawerpanelcontent branch December 11, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - DrawerPanelContent - hidden takes up space and breaks cypress

6 participants