Skip to content

Conversation

@kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Nov 21, 2024

What: Closes #11135

Turns out this was a demo issue rather than a component issue, caused by setState being called until the component rendering crashed.

@patternfly-build
Copy link
Collaborator

patternfly-build commented Nov 21, 2024

@tlabaj tlabaj requested a review from thatblindgeye November 22, 2024 19:35
Copy link
Member

@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tlabaj tlabaj merged commit c6f9df9 into patternfly:main Dec 2, 2024
10 checks passed
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

  • @patternfly/react-code-editor@6.1.0-prerelease.12
  • @patternfly/react-core@6.1.0-prerelease.12
  • @patternfly/react-docs@7.1.0-prerelease.20
  • @patternfly/react-drag-drop@6.1.0-prerelease.12
  • demo-app-ts@6.0.0-prerelease.41
  • @patternfly/react-table@6.1.0-prerelease.12
  • @patternfly/react-templates@6.1.0-prerelease.12

Thanks for your contribution! 🎉

mattnolting pushed a commit to mattnolting/patternfly-react that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menu - drilldown example showing an error after clicking the toggle

5 participants