feat(V5 Select/Dropdown/MenuContainer): arrow key handling to focus items #11249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-11249.surge.sh A11y report: https://patternfly-react-pr-11249-a11y.surge.sh |
adamviktora
requested review from
kmcfaul,
thatblindgeye and
tlabaj
and removed request for
kmcfaul and
thatblindgeye
tlabaj
approved these changes
Nov 22, 2024
thatblindgeye
approved these changes
Nov 26, 2024
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
mvollmer
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Dec 9, 2024
… changes The new PF version will move the keyboard focus into the SelectList of a opened Select when the user presses ArrowUp or ArrowDown keys. Further keyboard navigation then happens by moving the focus around in that list. However, TypeaheadSelect and MultiTypeaheadSelect templated implement their own custom keyboard navigation based on the (now broken) assumption that the text input stays in focus all the time. To restore the assumption, Select has a new "typeahead" variant that switches off its new key handling, letting the Typeahead templates live in the past for a little while longer. See patternfly/patternfly-react#11249
mvollmer
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Dec 9, 2024
… changes The new PF version will move the keyboard focus into the SelectList of a opened Select when the user presses ArrowUp or ArrowDown keys. Further keyboard navigation then happens by moving the focus around in that list. However, TypeaheadSelect and MultiTypeaheadSelect templated implement their own custom keyboard navigation based on the (now broken) assumption that the text input stays in focus all the time. To restore the assumption, Select has a new "typeahead" variant that switches off its new key handling, letting the Typeahead templates live in the past for a little while longer. See patternfly/patternfly-react#11249
allisonkarlitskaya
pushed a commit
to cockpit-project/cockpit
that referenced
this pull request
Dec 9, 2024
… changes The new PF version will move the keyboard focus into the SelectList of a opened Select when the user presses ArrowUp or ArrowDown keys. Further keyboard navigation then happens by moving the focus around in that list. However, TypeaheadSelect and MultiTypeaheadSelect templated implement their own custom keyboard navigation based on the (now broken) assumption that the text input stays in focus all the time. To restore the assumption, Select has a new "typeahead" variant that switches off its new key handling, letting the Typeahead templates live in the past for a little while longer. See patternfly/patternfly-react#11249
martinpitt
pushed a commit
to cockpit-project/cockpit
that referenced
this pull request
Dec 10, 2024
… changes The new PF version will move the keyboard focus into the SelectList of a opened Select when the user presses ArrowUp or ArrowDown keys. Further keyboard navigation then happens by moving the focus around in that list. However, TypeaheadSelect and MultiTypeaheadSelect templated implement their own custom keyboard navigation based on the (now broken) assumption that the text input stays in focus all the time. To restore the assumption, Select has a new "typeahead" variant that switches off its new key handling, letting the Typeahead templates live in the past for a little while longer. See patternfly/patternfly-react#11249
martinpitt
pushed a commit
to cockpit-project/cockpit
that referenced
this pull request
Dec 10, 2024
… changes The new PF version will move the keyboard focus into the SelectList of a opened Select when the user presses ArrowUp or ArrowDown keys. Further keyboard navigation then happens by moving the focus around in that list. However, TypeaheadSelect and MultiTypeaheadSelect templated implement their own custom keyboard navigation based on the (now broken) assumption that the text input stays in focus all the time. To restore the assumption, Select has a new "typeahead" variant that switches off its new key handling, letting the Typeahead templates live in the past for a little while longer. See patternfly/patternfly-react#11249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11131 for V5
V6 PR: #11132
MenuContainerto reflect changes that has been done in V6 (added theshouldFocusFirstItemOnOpen)shouldFocusFirstItemOnOpenprop?