chore: remove element-internals-polyfill#3128
Conversation
|
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "chore: remove element-internals-polyfill"
} |
|
/agentic_review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
This PR removes the element-internals-polyfill dependency and eliminates runtime/documentation references to it across the dev tooling, docs site, and component demos.
Changes:
- Dropped
element-internals-polyfillfrom tooling dependencies and the lockfile. - Removed polyfill imports from the dev server template, docs entrypoints, and multiple component demo pages.
- Removed Safari/polyfill guidance from affected component READMEs and removed docs-site asset/import-map wiring for the polyfill.
Reviewed changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/pfe-tools/package.json | Removes element-internals-polyfill from peer dependencies. |
| tools/pfe-tools/dev-server/plugins/templates/index.html | Stops importing the polyfill in the dev-server HTML template. |
| package-lock.json | Removes the polyfill package entry and associated dependency references. |
| elements/pf-v5-tabs/README.md | Removes Safari/polyfill note from tabs documentation. |
| elements/pf-v5-switch/README.md | Removes Safari/polyfill note from switch documentation. |
| elements/pf-v5-switch/demo/without-label.html | Removes polyfill import from demo. |
| elements/pf-v5-switch/demo/reversed.html | Removes polyfill import from demo. |
| elements/pf-v5-switch/demo/nested-in-label.html | Removes polyfill import from demo. |
| elements/pf-v5-switch/demo/index.html | Removes polyfill import from demo. |
| elements/pf-v5-switch/demo/disabled.html | Removes polyfill import from demo. |
| elements/pf-v5-switch/demo/checked.html | Removes polyfill import from demo. |
| elements/pf-v5-progress-stepper/demo/step-descriptions.html | Removes polyfill import from demo. |
| elements/pf-v5-progress-stepper/demo/info.html | Removes polyfill import from demo. |
| elements/pf-v5-progress-stepper/demo/index.html | Removes polyfill import from demo. |
| elements/pf-v5-progress-stepper/demo/danger.html | Removes polyfill import from demo. |
| elements/pf-v5-progress-stepper/demo/custom-icons.html | Removes polyfill import from demo. |
| elements/pf-v5-progress-stepper/demo/compact.html | Removes polyfill import from demo. |
| elements/pf-v5-progress-stepper/demo/alignment.html | Removes polyfill import from demo. |
| elements/pf-v5-jump-links/demo/vertical.html | Removes polyfill import from demo. |
| elements/pf-v5-jump-links/demo/vertical-with-label.html | Removes polyfill import from demo. |
| elements/pf-v5-jump-links/demo/scrollspy-with-subsections.html | Removes polyfill import from demo. |
| elements/pf-v5-jump-links/demo/label.html | Removes polyfill import from demo. |
| elements/pf-v5-jump-links/demo/index.html | Removes polyfill import from demo. |
| elements/pf-v5-jump-links/demo/expandable-vertical-with-subsection.html | Removes polyfill import from demo. |
| elements/pf-v5-jump-links/demo/centered-list.html | Removes polyfill import from demo. |
| elements/pf-v5-button/demo/variants.html | Removes polyfill import from demo. |
| elements/pf-v5-button/demo/stateful.html | Removes polyfill import from demo. |
| elements/pf-v5-button/demo/sizes.html | Removes polyfill import from demo. |
| elements/pf-v5-button/demo/index.html | Removes polyfill import from demo. |
| elements/pf-v5-button/demo/form-control.html | Removes polyfill import from demo. |
| elements/pf-v5-button/demo/block.html | Removes polyfill import from demo. |
| docs/main.mjs | Removes polyfill import from docs entry module. |
| docs/components/demos.html | Removes inline module import of the polyfill. |
| docs/_plugins/pfe-assets.cjs | Stops copying the polyfill assets into the docs site. |
| docs/_data/importMap.cjs | Removes polyfill from generated import map dependencies. |
| core/pfe-core/controllers/internals-controller.ts | Removes polyfill-related comment block around the disabled pseudo workaround. |
Comments suppressed due to low confidence (1)
core/pfe-core/controllers/internals-controller.ts:279
- The
#polyfillDisabledPseudo()cleanup left an orphaned// END polyfill-disabledmarker (the corresponding START marker/comments were removed). This looks like a partial removal and makes the method harder to read/search; either remove the END marker as well or restore a matching START marker if it's used for tooling.
#polyfillDisabledPseudo() {
const orig = (this.element as FACE).formDisabledCallback;
(this.element as FACE).formDisabledCallback = disabled => {
this._formDisabled = disabled;
orig?.call(this.host, disabled);
// END polyfill-disabled
};
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What I did