Merged
Conversation
the pull_request_target event runs in the base context, e.g. the main branch, not in the pr branch therefore this fails for new elements, because the commitlint script can't find the element name for an element which doesn't exist yet on main
|
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "chore: update commitlint.yml"
} |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ArathyKumar
approved these changes
Jun 5, 2025
Collaborator
ArathyKumar
left a comment
ArathyKumar
left a comment
There was a problem hiding this comment.
The changes look good to me.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the pull_request_target event runs in the base context, e.g. the main branch, not in the pr branch
therefore this fails for new elements, because the commitlint script can't find the element name for an element which doesn't exist yet on main
What I did