Skip to content

Bug/small bug fixes #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickfleith merged 2 commits into from
Aug 15, 2025
Merged

Bug/small bug fixes #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df2e155
Published datasets are private by default now
patrickfleith Aug 15, 2025
08520bd
fixing a bug
patrickfleith Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafast/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def push_to_hub(
self,
repo_id: str,
token: str | None = None,
private: bool = False,
private: bool = True,
commit_message: str | None = None,
train_size: float | None = None,
seed: int | None = None,
Expand Down
3 changes: 2 additions & 1 deletion datafast/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ def _get_mcq_specific_factors(config: MCQDatasetConfig) -> dict[str, int]:

def _get_mcq_num_expected_rows(config: MCQDatasetConfig, llms: list[LLMProvider], source_data_num_rows: int) -> int:
# factors = _get_mcq_specific_factors(config) # Not specific factors
source_data_num_rows = min(source_data_num_rows, config.sample_count)
if config.sample_count is not None:
source_data_num_rows = min(source_data_num_rows, config.sample_count)
num_llms = len(llms)
if config.prompts is None:
num_expanded_prompts = 1
Expand Down
Loading