chore(deps-dev): bump ws from 8.19.0 to 8.20.1#37
Conversation
Bumps [ws](https://github.com/websockets/ws) from 8.19.0 to 8.20.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.19.0...8.20.1) --- updated-dependencies: - dependency-name: ws dependency-version: 8.20.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
View your CI Pipeline Execution ↗ for commit c94eabb
☁️ Nx Cloud last updated this comment at |
Narrator
left a comment
There was a problem hiding this comment.
Reviewed the bump. Summary:
Scope: ws ^8.19.0 → ^8.20.1, devDependency on @domscribe/relay only. Lockfile correctly updated (transitive bumps in @fastify/websocket and @nuxt/devtools snapshots also point at 8.20.1).
Why it matters: 8.20.1 contains a security fix — uninitialized memory disclosure in websocket.close() when called with a TypedArray reason argument. Worth taking even on a devDep, since the relay's ws-server.spec.ts is the only consumer and could exercise the surface.
Surface check: ws is used in
packages/domscribe-relay/src/server/ws-server.ts:10—import type { WebSocket } from 'ws'(type-only)packages/domscribe-relay/src/server/ws-server.spec.ts:16—import WebSocket from 'ws'(runtime, test only)
Production code uses@fastify/websocket;wsis only a dev/types/test dep.
Local verification at head SHA c94eabb:
pnpm install --frozen-lockfilecleanpnpm --filter @domscribe/relay exec vitest run→ 47 files / 306 tests passed (incl.ws-server.spec.ts)pnpm --filter @domscribe/relay exec tsc --noEmit→ clean
CI failures: The two e2e (webpack-v5-react-18-{js,ts}) failures on run 26596278344 were GitHub infra flakes — both jobs died at the actions/checkout step with HTTP 500 from the promisor remote (fatal: could not fetch ... from promisor remote). Tests never ran. Rerun-failed-jobs triggered; awaiting green.
Recommend merge once the rerun goes green.
Bumps ws from 8.19.0 to 8.20.1.
Release notes
Sourced from ws's releases.
Commits
5d9b316[dist] 8.20.1c0327ec[security] Fix uninitialized memory disclosure inwebsocket.close()ce2a3d6[ci] Test on node 2658e45b8[ci] Do not test on node 255f26c24[ci] Run the lint step on node 248439255[dist] 8.20.0d3503c1[minor] Export thePerMessageDeflateclass and header utils3ee5349[api] Convert theisServerandmaxPayloadparameters to options91707b4[doc] Add missing space8b55319[pkg] Update eslint to version 10.0.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.