chore: polish release automation and installer docs#108
Open
pratik50 wants to merge 3 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoves Windows-installer and Docker publishing steps from CI/release, updates GoReleaser checksum naming, adds shell-specific PATH guidance to the installer, normalizes displayed Cobra ChangesRelease Pipeline Simplification and UX Improvements
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/install.sh (1)
69-75: ⚡ Quick winConsider using idiomatic Fish shell PATH setup.
The current instructions echo
fish_add_pathintoconfig.fish, causing it to execute on every shell startup. While functional, this is inefficient becausefish_add_pathmodifies universal variables and is designed to run once. The idiomatic Fish approach runs the command directly:🐟 Proposed idiomatic Fish instructions
fish) echo "$install_dir is not in your PATH. Add it with:" echo "" - echo " mkdir -p ~/.config/fish" - echo " echo 'fish_add_path $install_dir' >> ~/.config/fish/config.fish" - echo " source ~/.config/fish/config.fish" + echo " fish -c 'fish_add_path $install_dir'" ;;This approach:
- Runs from any shell (bash, zsh, or fish)
- Executes
fish_add_pathonce, persisting via Fish universal variables- Avoids redundant execution on every shell startup
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/install.sh` around lines 69 - 75, The fish case currently appends "fish_add_path $install_dir" to config.fish causing it to run on every startup; instead, invoke Fish once to add the path using a one-time universal change: replace the echo+append lines in the fish) block that reference install_dir with a command that runs fish -c 'fish_add_path "<install_dir>"' (or equivalent invocation using the install_dir variable) and remove the lines that write to ~/.config/fish/config.fish and source it so fish_add_path is applied once via Fish universal variables rather than on every shell startup.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@scripts/install.sh`:
- Around line 69-75: The fish case currently appends "fish_add_path
$install_dir" to config.fish causing it to run on every startup; instead, invoke
Fish once to add the path using a one-time universal change: replace the
echo+append lines in the fish) block that reference install_dir with a command
that runs fish -c 'fish_add_path "<install_dir>"' (or equivalent invocation
using the install_dir variable) and remove the lines that write to
~/.config/fish/config.fish and source it so fish_add_path is applied once via
Fish universal variables rather than on every shell startup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b1755cb5-65c5-4723-9dbb-373ca6efcdf8
⛔ Files ignored due to path filters (2)
docs/images/pb-promql-tui.pngis excluded by!**/*.pngdocs/images/pb-sql-tui.pngis excluded by!**/*.png
📒 Files selected for processing (5)
.github/workflows/build.yaml.github/workflows/release.yaml.goreleaser.ymlREADME.mdscripts/install.sh
💤 Files with no reviewable changes (3)
- .github/workflows/release.yaml
- .github/workflows/build.yaml
- .goreleaser.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Polishes the release setup after the initial release automation work.
Changes
install.shwith clearer PATH guidance for bash, zsh, and fish users~/.local/bininstallsNotes
HOMEBREW_TAP_GITHUB_TOKENis still required for Homebrew tap updatesSummary by CodeRabbit
Documentation
Installation Improvements
Release / CI
Packaging
Style