Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds validation and safe handling for invalid/malformed $regex in LiveQuery: tests, QueryTools change to return false on regex errors, and ParseLiveQueryServer updates to validate query constraints and catch per-subscription match errors to avoid crashing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #10197 +/- ##
==========================================
+ Coverage 92.20% 92.55% +0.35%
==========================================
Files 192 192
Lines 16259 16288 +29
Branches 190 199 +9
==========================================
+ Hits 14992 15076 +84
+ Misses 1250 1195 -55
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@spec/ParseLiveQuery.spec.js`:
- Around line 664-694: The test only creates a valid subscription
(validSubscription) so it never exercises the invalid-subscription path; update
the spec to either (a) seed a malformed subscription on the LiveQuery server
before saving the object (for example by creating a subscription that contains
an invalid $regex query for class 'TestObject') or (b) stub the LiveQuery
class's _matchesSubscription (or the _onAfterSave hook) to throw once when
checking subscriptions while leaving the valid Parse.Query.subscribe() active,
then assert the validSubscription still receives the 'update' event; locate and
modify the test around the validSubscription creation and the updatePromise so
the malformed subscription or stub is added before object.save() to ensure the
server code path handling bad subscriptions is exercised.
In `@spec/QueryTools.spec.js`:
- Around line 583-596: The test sets module-global regex timeout via
setRegexTimeout(100) but doesn't guarantee reset on failure; wrap the assertions
that call matchesQuery(...) in a try/finally block and move setRegexTimeout(0)
into the finally so setRegexTimeout is always called (restore to 0) even if an
expectation throws; locate the test case using setRegexTimeout and matchesQuery
in the spec and update it accordingly.
In `@src/LiveQuery/ParseLiveQueryServer.ts`:
- Around line 543-556: The regex validation currently only checks compilability
but doesn't reject non-string scalars (e.g. { $regex: 123 }); update the
validation in ParseLiveQueryServer (the block that inspects constraint.$regex)
to first enforce type guards: allow either a string or an object with a string
`source` (and optional string `flags`), and if not, throw new
Parse.Error(Parse.Error.INVALID_QUERY, 'Invalid regular expression: $regex must
be a string or { source: string, flags?: string }'); for the object branch also
validate that `constraint.$regex.source` is a string and
`constraint.$regex.flags` (if present) is a string before attempting new
RegExp(pattern, flags) so malformed payloads are rejected before being stored
(this aligns with how QueryTools.js expects string behavior).
- Around line 559-565: The forEach callbacks currently use expression-bodied
arrows that implicitly return the result of
this._validateQueryConstraints(subQuery), triggering the lint rule; update both
forEach usages (the one iterating constraint[op] inside the loop over
['$or','$and','$nor'] and the one iterating where[key]) to use block-bodied
callbacks that call this._validateQueryConstraints(subQuery); without returning
anything (e.g. change subQuery => this._validateQueryConstraints(subQuery) to
subQuery => { this._validateQueryConstraints(subQuery); }).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cfcf62d2-b054-4ad4-a53d-701cbb5ffc79
📒 Files selected for processing (4)
spec/ParseLiveQuery.spec.jsspec/QueryTools.spec.jssrc/LiveQuery/ParseLiveQueryServer.tssrc/LiveQuery/QueryTools.js
2 participants
Summary by CodeRabbit
Bug Fixes
Tests