Fix build-release-binaries workflow by switching from musl to glibc target#128
Merged
Fix build-release-binaries workflow by switching from musl to glibc target#128
Conversation
rockbmb
added
dependencies
rockbmb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the broken
build-release-binaries.yamlworkflow that was failing due to C++ standard library conflicts when building forx86_64-unknown-linux-musl.Changes
x86_64-unknown-linux-musltox86_64-unknown-linux-gnu.cargo/config.toml(no longer needed without musl)docjob in CI (left broken in Runcargo update#127)docCI job)Why?
The musl build was failing because RocksDB (a C++ dependency) couldn't link correctly with both libstdc++ and libc++ simultaneously. The glibc target builds cleanly and produces binaries compatible with all major Linux distributions.
Trade-offs