chore(deps): bump bulletin-deploy 0.7.24 -> 0.7.29#230
Merged
Conversation
Verified the consumed API surface is unchanged across the bump by diffing the shipped type declarations: deploy() signature, DeployContent/ DeployOptions/DeployResult, DEFAULT_MNEMONIC, and the DotNS methods we call (connect/checkOwnership/getUserPopStatus/isTestnet/disconnect) are all identical. Upstream changes are additive (manifest-publish exports, new optional fields), so no CLI code changes were needed. attemptTestnetTopUp is still internal so the bulletinTopUp.ts mirror stays; jsMerkle remains off (no confirmed merkleizeJS fix). Updates the pinned-version reference in CLAUDE.md.
UtkarshBhardwaj007
force-pushed
the
chore/bump-bulletin-deploy-0.7.29
branch
from
012f81b to
372a332
Compare
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ❌ FAILTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
bulletin-deployfrom0.7.24to0.7.29(latest). No CLI code changes were required — the API surface we consume is unchanged.API contract verification
Diffed the shipped
.d.tsdeclarations between 0.7.24 and 0.7.29 for every symbol the CLI imports. All unchanged or additive:deploy(content, domainName?, options?): Promise<DeployResult>DeployContent(string | Uint8Array | Uint8Array[])DeployResult(domainName/fullDomain/cid/ipfsCid?)DeployOptionsfields we pass (signer,signerAddress,mnemonic,rpc,attributes)DEFAULT_MNEMONIC: stringDotNSmethods we call (connect,checkOwnership,getUserPopStatus,isTestnet,disconnect)OwnershipResult,DotNSConnectOptionsUpstream changes are additive: new manifest-publish exports (
publishManifest, manifest schema/types),unpublish, new optionalDeployOptions/DotNSConnectOptionsfields. The onlyDeployOptionsremovals (name,description,automatedMirror) are fields the CLI never passes. The addedjitidependency is a transitive TS loader.Watch-items from CLAUDE.md (deliberately unchanged)
attemptTestnetTopUpis still an internalDotNSmethod (not exported at the package root), sosrc/utils/account/bulletinTopUp.tskeeps mirroring it per the invariant.jsMerklestays off —merkle.d.tschanged only additively and there's no confirmedmerkleizeJSfix, so flippingjsMerkle: true(which the invariant guards against) is out of scope.Verification
pnpm build,pnpm format:check,pnpm lint:license,pnpm test(593 passed, 1 skipped) all green. Also updates the pinned-version reference inCLAUDE.md.