test(e2e): add nightly-deploy-moddable cell + cleanup sweep#199
Merged
Conversation
Pre-creates a fresh paritytech/e2e-cli-moddable-<runId> public GH repo each nightly, pushes the frontend-only fixture into it, then runs dot deploy --moddable against that working dir. Asserts exit 0, the "Deploy complete" summary, the "Moddable: yes — <url>" line, and the registry has an entry for e2emoddab00.dot. Mirrors the cold-start sequence a Summit attendee takes (gh repo create → push → dot deploy --moddable) — the only test that exercises the per-run-fresh-repo path. mod.test.ts continues to cover the import half of the round-trip. Adds E2E_GH_PAT secret reference for paritytech/ repo create + delete. Replaces e2e-cleanup.yml's stub with a real 7-day sweep by topic e2e-test-fixture. Known limitation documented in-workflow: registry domain entry at e2emoddab00.dot accumulates re-publishes (one fixed domain, same owner — bounded + benign). Closes #107
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nightly-deploy-moddablecell intest-nightly-publishmatrix. Pre-creates a freshparitytech/e2e-cli-moddable-<runId>public GH repo each run, pushes thefrontend-onlyfixture into it, then runsdot deploy --moddablefrom that working dir. Asserts exit 0, "Deploy complete" summary, "Moddable: yes — <url>" line, and the registry has an entry fore2emoddab00.dot.gh repo create → push → dot deploy --moddable).mod.test.tscontinues to cover the import half of the round-trip.e2e-cleanup.yml's stub with a real 7-day sweep filtered by topice2e-test-fixture. Known limitation documented in-workflow: registry entry ate2emoddab00.dotaccumulates re-publishes (one fixed domain, same owner — bounded + benign).Closes #107.
Required before this can be green
Add the PAT value as a repo secret at https://github.com/paritytech/playground-cli/settings/secrets/actions named
E2E_GH_PAT(repo+delete_reposcopes). The PAT itself is labelled "Playground CLI cold start test" on Rebecca's GitHub account. Both the moddable cell and the cleanup sweep reference this secret. Rotate before 2026-08-20 (90-day expiry).Test plan
E2E_GH_PATsecret to repo settingsE2E Testsworkflow on this branch — confirmnightly-deploy-moddablecell appears and runsparitytech/e2e-cli-moddable-<runId>exists on GitHub withe2e-test-fixturetopice2emoddab00.dot(anydot mod e2emoddab00should succeed after this lands)E2E Cleanupworkflow — confirms sweep wiring without waiting a week; with a fresh moddable repo (<7 days old) it should list nothing to deleteDesign decisions (locked during planning)
e2emoddab00domain label (9-char base + 2 digits) is NoStatus-compatible so DotNS classification matches.gh repo createerrors — no retry, no auto-renaming. Auto-file-failure workflow opens an issue on the morning of (same pattern as fix(dot deploy): always install before build, surface build errors clearly #192).finallycleanup — cron is source of truth; in-test delete could race the bulletin upload serialisation.