Skip to content

Laravel 13.x Compatibility#73

Open
laravel-shift wants to merge 1 commit intoparagonie:masterfrom
laravel-shift:l13-compatibility
Open

Laravel 13.x Compatibility#73
laravel-shift wants to merge 1 commit intoparagonie:masterfrom
laravel-shift:l13-compatibility

Conversation

@laravel-shift
Copy link
Copy Markdown

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 13.x.

Before merging, you need to:

  • Checkout the l13-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Copy Markdown
Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^12.5. If you would like to also upgrade your tests, you may run the PHPUnit 12 Shift for free.

@laravel-shift
Copy link
Copy Markdown
Author

ℹ️ Shift did not find any dependencies for Laravel or popular community packages which were incompatible with Laravel 13.

@laravel-shift
Copy link
Copy Markdown
Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 13. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Copy Markdown
Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/constant_time_encoding.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "paragonie/constant_time_encoding": "dev-l13-compatibility",
    }
}

Finally, run: composer update

@paragonie-security
Copy link
Copy Markdown
Contributor

I genuinely do not understand this pull request.

Why should a PHP library that's framework-agnostic change their GitHub Actions workflow scripts to be "compatible" with Laravel 13.x? There are multiple category errors in the reasoning that leads up to this pull request.

Is there a human in the loop here, or did Shift give an LLM unfettered access to their GitHub account to lead up to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants