Fix race condition in analytics increment#22
Open
gul-ahmad wants to merge 1 commit intopanphp:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of the analytics increment method is susceptible to race conditions. In high-concurrency situations, this could lead to duplicate rows being created instead of proper increments.
Solution
Added database row-level locking using
lockForUpdate()within a transaction to ensure atomic operations:lockForUpdate()to prevent concurrent access to the same analytics rowChanges
increment()method inDatabaseAnalyticsRepositoryto use transactions and row-level locking