Warning in the console if same name pan elements are available on the page. #13
Open
msamgan wants to merge 2 commits intopanphp:mainfrom
Open
Warning in the console if same name pan elements are available on the page. #13msamgan wants to merge 2 commits intopanphp:mainfrom
msamgan wants to merge 2 commits intopanphp:mainfrom
Conversation
msamgan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behavior of the package takes the last element on the page into consideration, ignoring all others. But the user doesn't know if by mistake that happened.
This PR will give the user a warning in the console if any pan element has the same name. It's a warning because the package must have broken it would have been an error.
On-Page
In Console.
