Skip to content

Replace ensure_clean_store instances with temp_file in test_store.py #63364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asoledad33 wants to merge 2 commits into
base: main
Choose a base branch
from
+50 −51
Open

Replace ensure_clean_store instances with temp_file in test_store.py #63364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63bcd77
Replace ensure_clean_store instances with temp_file
asoledad33 Dec 15, 2025
9dd5423
Merge branch 'main' into temp_file-test-store
asoledad33 Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 50 additions & 51 deletions pandas/tests/io/pytables/test_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
)
from pandas.tests.io.pytables.common import (
_maybe_remove,
ensure_clean_store,
)

from pandas.io.pytables import (
Expand Down Expand Up @@ -100,14 +99,14 @@ def create_h5_and_return_checksum(tmp_path, track_times):
assert checksum_0_tt_true != checksum_1_tt_true


def test_iter_empty(setup_path):
with ensure_clean_store(setup_path) as store:
def test_iter_empty(temp_file):
with HDFStore(temp_file) as store:
# GH 12221
assert list(store) == []


def test_repr(setup_path, performance_warning, using_infer_string):
with ensure_clean_store(setup_path) as store:
def test_repr(temp_file, performance_warning, using_infer_string):
with HDFStore(temp_file) as store:
repr(store)
store.info()
store["a"] = Series(
Expand Down Expand Up @@ -154,7 +153,7 @@ def test_repr(setup_path, performance_warning, using_infer_string):
store.info()

# storers
with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
df = DataFrame(
1.1 * np.arange(120).reshape((30, 4)),
columns=Index(list("ABCD"), dtype=object),
Expand All @@ -167,8 +166,8 @@ def test_repr(setup_path, performance_warning, using_infer_string):
str(s)


def test_contains(setup_path):
with ensure_clean_store(setup_path) as store:
def test_contains(temp_file):
with HDFStore(temp_file) as store:
store["a"] = Series(
np.arange(10, dtype=np.float64), index=date_range("2020-01-01", periods=10)
)
Expand Down Expand Up @@ -202,8 +201,8 @@ def test_contains(setup_path):
assert "node())" in store


def test_versioning(setup_path):
with ensure_clean_store(setup_path) as store:
def test_versioning(temp_file):
with HDFStore(temp_file) as store:
store["a"] = Series(
np.arange(10, dtype=np.float64), index=date_range("2020-01-01", periods=10)
)
Expand Down Expand Up @@ -259,7 +258,7 @@ def test_versioning(setup_path):
),
],
)
def test_walk(where, expected):
def test_walk(temp_path, where, expected):
# GH10143
objs = {
"df1": DataFrame([1, 2, 3]),
Expand All @@ -273,7 +272,7 @@ def test_walk(where, expected):
"tb2": np.array([(7, 8, 9), (10, 11, 12)], dtype="i,i,i"),
}

with ensure_clean_store("walk_groups.hdf", mode="w") as store:
with HDFStore(temp_path / "walk_groups.hdf", mode="w") as store:
store.put("/first_group/df1", objs["df1"])
store.put("/first_group/df2", objs["df2"])
store.put("/second_group/df3", objs["df3"])
Expand All @@ -299,8 +298,8 @@ def test_walk(where, expected):
tm.assert_series_equal(obj, objs[leaf])


def test_getattr(setup_path):
with ensure_clean_store(setup_path) as store:
def test_getattr(temp_file):
with HDFStore(temp_file) as store:
s = Series(
np.arange(10, dtype=np.float64), index=date_range("2020-01-01", periods=10)
)
Expand Down Expand Up @@ -403,8 +402,8 @@ def test_to_hdf_errors(tmp_path, format, setup_path, using_infer_string):
tm.assert_series_equal(result, expected)


def test_create_table_index(setup_path):
with ensure_clean_store(setup_path) as store:
def test_create_table_index(temp_file):
with HDFStore(temp_file) as store:

def col(t, column):
return getattr(store.get_storer(t).table.cols, column)
Expand Down Expand Up @@ -436,10 +435,10 @@ def col(t, column):
store.create_table_index("f2")


def test_create_table_index_data_columns_argument(setup_path):
def test_create_table_index_data_columns_argument(temp_file):
# GH 28156

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:

def col(t, column):
return getattr(store.get_storer(t).table.cols, column)
Expand Down Expand Up @@ -470,22 +469,22 @@ def col(t, column):
store.create_table_index("f", columns=["string2"])


def test_mi_data_columns(setup_path):
def test_mi_data_columns(temp_file):
# GH 14435
idx = MultiIndex.from_arrays(
[date_range("2000-01-01", periods=5), range(5)], names=["date", "id"]
)
df = DataFrame({"a": [1.1, 1.2, 1.3, 1.4, 1.5]}, index=idx)

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
store.append("df", df, data_columns=True)

actual = store.select("df", where="id == 1")
expected = df.iloc[[1], :]
tm.assert_frame_equal(actual, expected)


def test_table_mixed_dtypes(setup_path):
def test_table_mixed_dtypes(temp_file):
# frame
df = DataFrame(
1.1 * np.arange(120).reshape((30, 4)),
Expand All @@ -506,12 +505,12 @@ def test_table_mixed_dtypes(setup_path):
df.loc[df.index[3:6], ["obj1"]] = np.nan
df = df._consolidate()

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
store.append("df1_mixed", df)
tm.assert_frame_equal(store.select("df1_mixed"), df)


def test_calendar_roundtrip_issue(setup_path):
def test_calendar_roundtrip_issue(temp_file):
# 8591
# doc example from tseries holiday section
weekmask_egypt = "Sun Mon Tue Wed Thu"
Expand All @@ -528,7 +527,7 @@ def test_calendar_roundtrip_issue(setup_path):

s = Series(dts.weekday, dts).map(Series("Mon Tue Wed Thu Fri Sat Sun".split()))

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
store.put("fixed", s)
result = store.select("fixed")
tm.assert_series_equal(result, s)
Expand All @@ -538,8 +537,8 @@ def test_calendar_roundtrip_issue(setup_path):
tm.assert_series_equal(result, s)


def test_remove(setup_path):
with ensure_clean_store(setup_path) as store:
def test_remove(temp_file):
with HDFStore(temp_file) as store:
ts = Series(
np.arange(10, dtype=np.float64), index=date_range("2020-01-01", periods=10)
)
Expand Down Expand Up @@ -583,8 +582,8 @@ def test_remove(setup_path):
assert len(store) == 0


def test_same_name_scoping(setup_path):
with ensure_clean_store(setup_path) as store:
def test_same_name_scoping(temp_file):
with HDFStore(temp_file) as store:
df = DataFrame(
np.random.default_rng(2).standard_normal((20, 2)),
index=date_range("20130101", periods=20, unit="ns"),
Expand All @@ -606,15 +605,15 @@ def test_same_name_scoping(setup_path):
tm.assert_frame_equal(result, expected)


def test_store_index_name(setup_path):
def test_store_index_name(temp_file):
df = DataFrame(
1.1 * np.arange(120).reshape((30, 4)),
columns=Index(list("ABCD")),
index=Index([f"i-{i}" for i in range(30)]),
)
df.index.name = "foo"

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
store["frame"] = df
recons = store["frame"]
tm.assert_frame_equal(recons, df)
Expand Down Expand Up @@ -653,22 +652,22 @@ def test_store_index_name_numpy_str(tmp_path, table_format, setup_path, unit, tz
assert isinstance(df2.columns.name, str)


def test_store_series_name(setup_path):
def test_store_series_name(temp_file):
df = DataFrame(
1.1 * np.arange(120).reshape((30, 4)),
columns=Index(list("ABCD")),
index=Index([f"i-{i}" for i in range(30)]),
)
series = df["A"]

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
store["series"] = series
recons = store["series"]
tm.assert_series_equal(recons, series)


def test_overwrite_node(setup_path):
with ensure_clean_store(setup_path) as store:
def test_overwrite_node(temp_file):
with HDFStore(temp_file) as store:
store["a"] = DataFrame(
np.random.default_rng(2).standard_normal((10, 4)),
columns=Index(list("ABCD")),
Expand All @@ -682,14 +681,14 @@ def test_overwrite_node(setup_path):
tm.assert_series_equal(store["a"], ts)


def test_coordinates(setup_path):
def test_coordinates(temp_file):
df = DataFrame(
np.random.default_rng(2).standard_normal((10, 4)),
columns=Index(list("ABCD")),
index=date_range("2000-01-01", periods=10, freq="B"),
)

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
_maybe_remove(store, "df")
store.append("df", df)

Expand Down Expand Up @@ -739,7 +738,7 @@ def test_coordinates(setup_path):
# but expect freq="18B"

# pass array/mask as the coordinates
with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
df = DataFrame(
np.random.default_rng(2).standard_normal((1000, 2)),
index=date_range("20000101", periods=1000),
Expand Down Expand Up @@ -800,8 +799,8 @@ def test_coordinates(setup_path):
tm.assert_frame_equal(result, expected)


def test_start_stop_table(setup_path):
with ensure_clean_store(setup_path) as store:
def test_start_stop_table(temp_file):
with HDFStore(temp_file) as store:
# table
df = DataFrame(
{
Expand All @@ -822,9 +821,9 @@ def test_start_stop_table(setup_path):
tm.assert_frame_equal(result, expected)


def test_start_stop_multiple(setup_path):
def test_start_stop_multiple(temp_file):
# GH 16209
with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
df = DataFrame({"foo": [1, 2], "bar": [1, 2]})

store.append_to_multiple(
Expand All @@ -837,8 +836,8 @@ def test_start_stop_multiple(setup_path):
tm.assert_frame_equal(result, expected)


def test_start_stop_fixed(setup_path):
with ensure_clean_store(setup_path) as store:
def test_start_stop_fixed(temp_file):
with HDFStore(temp_file) as store:
# fixed, GH 8287
df = DataFrame(
{
Expand Down Expand Up @@ -883,12 +882,12 @@ def test_start_stop_fixed(setup_path):
df.iloc[8:10, -2] = np.nan


def test_select_filter_corner(setup_path, request):
def test_select_filter_corner(temp_file, request):
df = DataFrame(np.random.default_rng(2).standard_normal((50, 100)))
df.index = [f"{c:3d}" for c in df.index]
df.columns = [f"{c:3d}" for c in df.columns]

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
store.put("frame", df, format="table")

request.applymarker(
Expand Down Expand Up @@ -921,7 +920,7 @@ def test_path_pathlib():


@pytest.mark.parametrize("start, stop", [(0, 2), (1, 2), (None, None)])
def test_contiguous_mixed_data_table(start, stop, setup_path):
def test_contiguous_mixed_data_table(start, stop, temp_file):
# GH 17021
df = DataFrame(
{
Expand All @@ -930,7 +929,7 @@ def test_contiguous_mixed_data_table(start, stop, setup_path):
}
)

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
store.append("test_dataset", df)

result = store.select("test_dataset", start=start, stop=stop)
Expand Down Expand Up @@ -1017,14 +1016,14 @@ def test_duplicate_column_name(tmp_path, setup_path):
assert other.equals(df)


def test_preserve_timedeltaindex_type(setup_path, unit):
def test_preserve_timedeltaindex_type(temp_file, unit):
# GH9635
df = DataFrame(np.random.default_rng(2).normal(size=(10, 5)))
df.index = timedelta_range(
start="0s", periods=10, freq="1s", name="example", unit=unit
)

with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
store["df"] = df
tm.assert_frame_equal(store["df"], df)

Expand Down Expand Up @@ -1090,10 +1089,10 @@ def test_to_hdf_with_object_column_names_should_run(tmp_path, setup_path, dtype)
assert len(result)


def test_hdfstore_strides(setup_path):
def test_hdfstore_strides(temp_file):
# GH22073
df = DataFrame({"a": [1, 2, 3, 4], "b": [5, 6, 7, 8]})
with ensure_clean_store(setup_path) as store:
with HDFStore(temp_file) as store:
store.put("df", df)
assert df["a"].values.strides == store["df"]["a"].values.strides

Expand Down
Loading