replaced all Appender、Substitution、doc decorators in pandas/pandas/core/frame.py. #63357
Conversation
rhshadrach
left a comment
rhshadrach
left a comment
There was a problem hiding this comment.
The only way I think this is mergable is if the CI can get to green and this produces nearly identical HTML output to what's on main.
I'll be willing to check once the CI gets to green, but I'd suggest smaller PRs to tackle this issue.
|
I took a look, the diff on just |
|
I do just as the issue says, print the __doc__ variable and paste it in the code, but I changed some lines since the pre-commit program reports that some lines are too long, should this make the difference? |
|
Or should the indents in the docstring cause the difference?Every line in the docstring is indented to be aligned with the code block, ortherwise the pre-commit program will do it automatically. By the way, where can I find the files reference/api/pandas.DataFrame.*.html? I want to take them as reference. |
There was a problem hiding this comment.
Every PR must be reviewed to ensure it has been done correctly. The larger the PR, the more likely it is that errors will be introduced. I personally am not willing to review a 6k+ line PR unless it is in exceptional circumstances, perhaps another core member will.
By the way, where can I find the files reference/api/pandas.DataFrame.*.html? I want to take them as reference.
In the doc/build/html directory.
| >>> print(df.to_string()) | ||
| col1 col2 | ||
| col1 col2 | ||
| 0 1 4 | ||
| 1 2 5 | ||
| 2 3 6 |
There was a problem hiding this comment.
Here is an example of an error being introduced in this PR.
There was a problem hiding this comment.
yes, I will break this PR into several smaller ones, but I will temperally reserve this one, once I make the new one, I want to remind you to review the new ones, is that OK?
2 participants
replaced all Appender、Substitution、doc decorators in pandas/pandas/core/frame.py.
ref #62437