STY: Add strict parameter to zip() in pandas/core/reshape/concat #63350
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Dec 14, 2025
pandas/core/reshape/concat.py
Outdated
| or all( | ||
| prev is curr for prev, curr in zip(non_concat_axis, non_concat_axis[1:]) | ||
| prev is curr | ||
| for prev, curr in zip( |
Member
There was a problem hiding this comment.
Can you use itertools.pairwise for both changes?
mroeschke
approved these changes
Dec 14, 2025
Member
|
Thanks @Unkwn1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of the addition from #62843, some calls to zip() in pandas/core/reshape/concat.py did not adhere to Ruff rule B905 as outlined in #62434.
Also, I noticed there are a lot of files still listed as "Todo: fix B905" in pyproject.toml even though all of their zip() calls seem to be already fixed to have a "strict" parameter. Shouldn't those files be removed from the todo list or is there something else I'm missing here?