Skip to content

drop python<=3.7 support #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kloczek wants to merge 2 commits into
base: main
Choose a base branch
from
Open

drop python<=3.7 support #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0abaac
drop python<3=3.7 support
kloczek Jun 26, 2024
e046953
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions specfile/changelog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,15 +400,13 @@ def guess_packager() -> str:
if shutil.which("git"):
email = subprocess.run(
["git", "config", "user.email"],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
universal_newlines=True,
capture_output=True,
text=True,
).stdout.strip()
fullname = subprocess.run(
["git", "config", "user.name"],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
universal_newlines=True,
capture_output=True,
text=True,
).stdout.strip()
if not fullname:
fullname = _getent_name()
Expand Down
10 changes: 3 additions & 7 deletions tests/unit/test_guess_packager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,16 @@ def set_packager_git(monkeypatch: MonkeyPatch, tmp_path: Path) -> str:
packager = "Packager, Patty <packager@patty.dev>"

monkeypatch.chdir(tmp_path)
subprocess.run(
["git", "init", "."], check=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE
)
subprocess.run(["git", "init", "."], check=True, capture_output=True)
subprocess.run(
["git", "config", "user.name", "Packager, Patty"],
check=True,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
capture_output=True,
)
subprocess.run(
["git", "config", "user.email", "packager@patty.dev"],
check=True,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
capture_output=True,
)
return packager

Expand Down