Skip to content

bug fix where param_to_type_map was never populated causing type to b… #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olaghattas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug fix where param_to_type_map was never populated causing type to b… #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pddl_parser/src/pddl_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ namespace pddl_lib {
std::string_view section;
std::string matched_token;
std::vector<std::string_view> all_comments;

std::unordered_map<std::string, std::string> param_to_type_map;

std::tie(section, remaining) = getNextParen(content);
const auto strings = parseVector(section, {'\t', '\n', ' '}, all_comments);
Expand Down Expand Up @@ -144,6 +146,13 @@ namespace pddl_lib {
// return fmt::format("ERROR line {}: missing ':objects' keyword", get_line_num(content, substrings[0]));
problem.objects = parse_instantiated_params(
std::vector<std::string_view>(substrings.begin() + 1, substrings.end()));

// <-- Populate param_to_type_map here

for (auto &obj : problem.objects) {
param_to_type_map[obj.name] = obj.type;
}

ind++;
std::tie(section, remaining) = getNextParen(strings[ind]);
substrings = parseVector(section, {'\t', '\n', ' '}, all_comments);
Expand All @@ -152,7 +161,7 @@ namespace pddl_lib {
if (substrings[0] != ":init") {
return fmt::format("ERROR line {}: missing ':init' keyword", get_line_num(content, substrings[0]));
}
std::unordered_map<std::string, std::string> param_to_type_map;

for (const auto &str: std::vector<std::string_view>(substrings.begin() + 1, substrings.end())) {
std::tie(section, remaining) = getNextParen(str);
auto subsubstrings = parseVector(section, {'\t', '\n', ' '}, all_comments);
Expand Down