Fix threading in calling PyOS_InputHook from new REPL #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal
force-pushed
the
gh-119842
branch
4 times, most recently
from
ed164d7 to
d4ab42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a proof-of-concept for what seems to make this work.
Since the PyOS_InputHook implementation in Tkinter sets the thread state, we need to allow threads around calling it. I'm not sure that's possible directly from Python (maybe it is), so I just added a C function to handle this. This seems to make things work correctly, at least for matplotlib and the Tkinter reproducer here.
I'm not sure the new function is in the right file.