Skip to content

feat(async-search): fetch fractions one by one to avoid global lock#424

Open
eguguchkin wants to merge 5 commits into
mainfrom
423-single-frac-access
Open

feat(async-search): fetch fractions one by one to avoid global lock#424
eguguchkin wants to merge 5 commits into
mainfrom
423-single-frac-access

Conversation

@eguguchkin
Copy link
Copy Markdown
Collaborator

Fixes #423


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

❌ Patch coverage is 69.38776% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.60%. Comparing base (03b2cad) to head (3a125af).

Files with missing lines Patch % Lines
frac/sealed.go 21.42% 10 Missing and 1 partial ⚠️
asyncsearcher/async_searcher.go 62.50% 6 Missing and 3 partials ⚠️
frac/remote.go 20.00% 3 Missing and 1 partial ⚠️
fracmanager/fraction_registry.go 83.33% 3 Missing ⚠️
skipmaskmanager/skip_mask_manager.go 75.00% 1 Missing and 1 partial ⚠️
storeapi/grpc_async_search.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   70.62%   70.60%   -0.02%     
==========================================
  Files         219      219              
  Lines       16970    17009      +39     
==========================================
+ Hits        11985    12010      +25     
- Misses       4089     4101      +12     
- Partials      896      898       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin force-pushed the 423-single-frac-access branch from 5d12ddb to bda808a Compare May 14, 2026 08:33
@eguguchkin eguguchkin requested review from dkharms and forshev May 15, 2026 00:05
@github-actions
Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
MutexListAppend-4 e0cf43 edfbf5
218.29 MB/s 196.97 MB/s 0.90 🔴

Comment thread skipmaskmanager/skip_mask_manager.go Outdated
Comment thread asyncsearcher/async_searcher.go Outdated
Comment thread fracmanager/fraction_registry.go
Comment thread skipmaskmanager/skip_mask_manager.go Outdated
@eguguchkin eguguchkin added this to the v0.73.0 milestone May 18, 2026
@eguguchkin
Copy link
Copy Markdown
Collaborator Author

@seqbenchbot up main

@seqbenchbot
Copy link
Copy Markdown
Collaborator

seqbenchbot commented May 18, 2026

Oh-oh, @eguguchkin ('>o.o)'>!

Something went wrong and I couldn't process your request.
Please take a closer look at error message:

expected "<scenario>"

@eguguchkin
Copy link
Copy Markdown
Collaborator Author

@seqbenchbot up main mixed

@seqbenchbot
Copy link
Copy Markdown
Collaborator

seqbenchbot commented May 18, 2026

Nice, @eguguchkin <(-^,^-)=b!

Your request was successfully served.
Identificator for your ongoing benchmark - be6c3c1d.

Here is a list of helpful links:

  • Take a look at Grafana dashboard;
  • Live-tailing logs are also available;

Have a great time!

@eguguchkin
Copy link
Copy Markdown
Collaborator Author

@seqbenchbot --help

@seqbenchbot
Copy link
Copy Markdown
Collaborator

seqbenchbot commented May 18, 2026

Hey, @eguguchkin *\ (^_^)}!

Below is the help message you've requested.
Please notice that I support shell-like interface for interaction!

Usage: @seqbenchbot <command>

Flags:
  -h, --help    Show context-sensitive help.

Commands:
  up <baseline> <scenario> [flags]
    Start a new benchmark scenario

  down <id>
    Stop the benchmark scenario

  list
    List all running benchmark scenarios

Run "@seqbenchbot <command> --help" for more information on a command.

@eguguchkin
Copy link
Copy Markdown
Collaborator Author

@seqbenchbot help

@seqbenchbot
Copy link
Copy Markdown
Collaborator

seqbenchbot commented May 18, 2026

Oh-oh, @eguguchkin ('>o.o)'>!

Something went wrong and I couldn't process your request.
Please take a closer look at error message:

unexpected argument help

@github-actions
Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggWide/size=1000000-4 e0cf43 fead3d
471.00 B/op 553.00 B/op 1.17 🔴
MutexListAppend-4 e0cf43 fead3d
218.29 MB/s 193.26 MB/s 0.89 🔴
74001822.00 ns/op 82790304.00 ns/op 1.12 🔴

@eguguchkin eguguchkin modified the milestones: v0.73.0, v0.71.0 May 18, 2026
@eguguchkin
Copy link
Copy Markdown
Collaborator Author

@seqbenchbot down be6c3c1d

@seqbenchbot
Copy link
Copy Markdown
Collaborator

seqbenchbot commented May 18, 2026

Nice, @eguguchkin <(-^,^-)=b!

The benchmark with identificator be6c3c1d was finished.
I've prepared a summary for you. Click on Show summary button to see it:

Show summary
Query Type mean (ms) stddev (ms) p(50) (ms) p(95) (ms) p(99) (ms) iterations
base comp diff base comp diff base comp diff base comp diff base comp diff base comp diff
bulk
warm 63.79 64.28 +0.76% 21.81 21.20 -2.81% 58.00 59.00 +1.72% 104.00 104.00 0.00% 151.00 147.00 -2.65% 39543.00 39670.00 +0.32%
service:payment-backend-eu
AND k8s_namespace:prod
AND level:[0 to 3]
AND (
    message:'failed'
    OR message:'timeout'
)
warm 60.86 61.54 +1.11% 19.96 19.56 -1.98% 55.00 56.00 +1.82% 97.00 100.00 +3.09% 141.50 144.50 +2.12% 8086.00 8118.00 +0.40%

Have a great time!

@eguguchkin eguguchkin force-pushed the 423-single-frac-access branch from 0b39dd2 to 83e9199 Compare May 18, 2026 22:48
@eguguchkin eguguchkin force-pushed the 423-single-frac-access branch from 83e9199 to 3a125af Compare May 18, 2026 22:54
@github-actions
Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
ProcessDocuments-4 03b2ca 1bb1cf
346.00 B/op 28585.00 B/op 82.62 🔴

@github-actions
Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
ProcessDocuments-4 03b2ca 707cf6
346.00 B/op 28307.00 B/op 81.81 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async search: adapt to fetch fractions one by one instead of locking all fractions

5 participants