Skip to content

Conversation

@forshev
Copy link
Contributor

@forshev forshev commented Feb 6, 2026

Description

Skip evicted fracs in async search


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@forshev forshev added this to the v0.66.0 milestone Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
GenerateDocs-4 6ae568 044fcb
957.90 ns/op 1132.00 ns/op 1.18 🔴
MutexListAppend-4 6ae568 044fcb
184.44 MB/s 166.21 MB/s 0.90 🔴

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.46%. Comparing base (1d2edc4) to head (19219ab).

Files with missing lines Patch % Lines
asyncsearcher/async_searcher.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   71.55%   71.46%   -0.09%     
==========================================
  Files         204      204              
  Lines       14928    14931       +3     
==========================================
- Hits        10681    10671      -10     
- Misses       3480     3489       +9     
- Partials      767      771       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@forshev forshev requested a review from moflotas February 9, 2026 10:51
@forshev forshev force-pushed the 0-async-search-check-frac-exists-before-search branch from 5d17d99 to 13a8495 Compare February 10, 2026 09:50
@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Bitmask-4 b9c2c0 7046c4
0.00 B/op 3.00 B/op NaN 🔴
GenerateDocs-4 b9c2c0 7046c4
935.60 ns/op 1143.00 ns/op 1.22 🔴

@forshev forshev force-pushed the 0-async-search-check-frac-exists-before-search branch from 13a8495 to 19219ab Compare February 10, 2026 12:07
@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/large-4 1d2edc 1b8dd4
13163.26 MB/s 11341.66 MB/s 0.86 🔴
1245.00 ns/op 1445.00 ns/op 1.16 🔴
FindSequence_Random/medium-4 1d2edc 1b8dd4
11008.63 MB/s 7497.74 MB/s 0.68 🔴
93.02 ns/op 136.60 ns/op 1.47 🔴
GenerateDocs-4 1d2edc 1b8dd4
948.80 ns/op 1127.00 ns/op 1.19 🔴

@forshev forshev merged commit 772ba37 into main Feb 10, 2026
8 checks passed
@forshev forshev deleted the 0-async-search-check-frac-exists-before-search branch February 10, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants