-
Notifications
You must be signed in to change notification settings - Fork 9
refactor: benchmarks tidied up #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Alhanaqtah hey! Sorry for a quite late answer. Could you please fix issues I've left and also do following:
|
c941078 to
c63dcd7
Compare
c63dcd7 to
ccdaa3b
Compare
ccdaa3b to
8da327c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
- Coverage 71.49% 71.42% -0.07%
==========================================
Files 204 204
Lines 14857 14738 -119
==========================================
- Hits 10622 10527 -95
+ Misses 3471 3449 -22
+ Partials 764 762 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Alhanaqtah Hey! I am ready to merge this one. Could you please fix the merge conflicts? |
…h/seq-db into 263-tidy-up-benchmarks
Description
The tests have been finalized to use the new API (
b.Loop()). Also, the dependence onb.Nin determining the size of the generated data has been eliminated.If you have used LLM/AI assistance please provide model name and full prompt: