Skip to content

feat: uniqCount aggregation#298

Merged
cheb0 merged 17 commits intomainfrom
295-unique-count
Feb 10, 2026
Merged

feat: uniqCount aggregation#298
cheb0 merged 17 commits intomainfrom
295-unique-count

Conversation

@cheb0
Copy link
Member

@cheb0 cheb0 commented Dec 19, 2025

Description

Fixes #295


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 86.25000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.56%. Comparing base (b9c2c02) to head (a7c9b9b).

Files with missing lines Patch % Lines
frac/processor/aggregator.go 80.95% 2 Missing and 2 partials ⚠️
proxy/search/ingestor.go 63.63% 3 Missing and 1 partial ⚠️
storeapi/grpc_v1.go 0.00% 1 Missing and 1 partial ⚠️
cmd/seq-db/seq-db.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   71.49%   71.56%   +0.06%     
==========================================
  Files         204      204              
  Lines       14857    14928      +71     
==========================================
+ Hits        10622    10683      +61     
- Misses       3471     3479       +8     
- Partials      764      766       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cheb0 cheb0 force-pushed the 295-unique-count branch 3 times, most recently from 6b82090 to 10737f2 Compare December 22, 2025 08:42
@eguguchkin eguguchkin requested review from eguguchkin and removed request for dkharms January 19, 2026 09:51
@eguguchkin eguguchkin modified the milestones: v0.65.0, v0.66.0 Jan 19, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/large-4 77fae2 b57eaa
13987.92 MB/s 12082.33 MB/s 0.86 🔴
1171.00 ns/op 1356.00 ns/op 1.16 🔴
FindSequence_Random/tiny-4 77fae2 b57eaa
2850.02 MB/s 2536.33 MB/s 0.89 🔴
22.46 ns/op 25.23 ns/op 1.12 🔴
GenerateDocs-4 77fae2 b57eaa
949.50 ns/op 1121.00 ns/op 1.18 🔴

cheb0 added 3 commits February 9, 2026 09:35
# Conflicts:
#	pkg/seqproxyapi/v1/seq_proxy_api.pb.go
#	pkg/storeapi/store_api.pb.go
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Bitmask-4 6ae568 bd827e
0.00 B/op 3.00 B/op NaN 🔴
FindSequence_Random/medium-4 6ae568 bd827e
13517.73 MB/s 10599.31 MB/s 0.78 🔴
75.75 ns/op 96.61 ns/op 1.28 🔴
FindSequence_Random/small-4 6ae568 bd827e
5683.27 MB/s 3417.27 MB/s 0.60 🔴
45.04 ns/op 74.91 ns/op 1.66 🔴
GenerateDocs-4 6ae568 bd827e
957.90 ns/op 1143.00 ns/op 1.19 🔴
ProcessDocuments-4 6ae568 bd827e
4.00 allocs/op 5.00 allocs/op 1.25 🔴

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Bitmask-4 b9c2c0 cbceef
0.00 B/op 3.00 B/op NaN 🔴
FindSequence_Random/tiny-4 b9c2c0 cbceef
2406.53 MB/s 2164.50 MB/s 0.90 🔴
26.59 ns/op 29.57 ns/op 1.11 🔴
GenerateDocs-4 b9c2c0 cbceef
935.60 ns/op 1166.00 ns/op 1.25 🔴

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/small-4 b9c2c0 5c34f9
4713.98 MB/s 3836.26 MB/s 0.81 🔴
54.31 ns/op 66.73 ns/op 1.23 🔴
GenerateDocs-4 b9c2c0 5c34f9
935.60 ns/op 1151.00 ns/op 1.23 🔴

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Bitmask-4 b9c2c0 6e2b52
0.00 B/op 3.00 B/op NaN 🔴
FindSequence_Random/large-4 b9c2c0 6e2b52
12632.84 MB/s 11367.86 MB/s 0.90 🔴
FindSequence_Random/medium-4 b9c2c0 6e2b52
10894.16 MB/s 7140.92 MB/s 0.66 🔴
94.00 ns/op 143.40 ns/op 1.53 🔴
FindSequence_Random/small-4 b9c2c0 6e2b52
4713.98 MB/s 3238.19 MB/s 0.69 🔴
54.31 ns/op 79.06 ns/op 1.46 🔴
GenerateDocs-4 b9c2c0 6e2b52
935.60 ns/op 1132.00 ns/op 1.21 🔴

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/medium-4 b9c2c0 432f19
10894.16 MB/s 9387.04 MB/s 0.86 🔴
94.00 ns/op 109.10 ns/op 1.16 🔴
GenerateDocs-4 b9c2c0 432f19
935.60 ns/op 1151.00 ns/op 1.23 🔴

@cheb0 cheb0 merged commit 1d2edc4 into main Feb 10, 2026
8 checks passed
@cheb0 cheb0 deleted the 295-unique-count branch February 10, 2026 12:03
@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/small-4 b9c2c0 601915
4713.98 MB/s 2396.18 MB/s 0.51 🔴
54.31 ns/op 106.80 ns/op 1.97 🔴
MutexListAppend-4 b9c2c0 601915
179.11 MB/s 152.84 MB/s 0.85 🔴
89328404.00 ns/op 104681779.00 ns/op 1.17 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add UniqCount aggregation function

4 participants