various ipv6 fixes #585
Merged
various ipv6 fixes #585
+1,070
−907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rcgoodfellow
commented
Dec 18, 2025
rcgoodfellow
commented
- fix sync of v6 routes to dendrite
rcgoodfellow
commented
Dec 29, 2025
| }; | ||
| } | ||
|
|
||
| dpd_routes |
Collaborator
Author
There was a problem hiding this comment.
This was doing the same thing as the result construction above, but ignoring the mg-lower tag and throwing out the result. This change uses result instead.
rcgoodfellow
commented
Dec 29, 2025
| let cidr = Ipv6Net::new(p.value, p.length)?; | ||
| let dpd_routes = rt | ||
| .block_on(async { dpd.route_ipv6_get(&cidr).await })? | ||
| let dpd_routes = |
Collaborator
Author
There was a problem hiding this comment.
This change lines up with how we are doing things for IPv4. In particular looking for a route that is not found in dpd is not an error, it's a diff to be reconciled. This was breaking v6 routing in initial testing.
taspelund
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.