Add humility-caboose and humility-cmd-caboose#696
Open
mkeeter wants to merge 1 commit into
Open
Conversation
941a313 to
f6fc329
Compare
f6fc329 to
eed2667
Compare
eed2667 to
6f811a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is helpful to read the caboose without knowing anything about the image (e.g. no archive). Fortunately, that is part of the caboose's design! This PR adds a
humility caboose readsubcommand which prints a raw caboose.It is a library-first PR:
humility-cabooseis a library for pulling the caboose from an image, with strongly typed errorshumility-cmd-cabooseis a wrapper which prints it out (and is linked into the mainhumilitybinary)#![warn(missing_docs)])There's a bit of copy-pasta from
hubtools, but that implementation expects to operate on aHubrisArchivein memory (rather than a raw byte array). I think the copy-pasta is minimal / stable enough to not be a big deal, but can revisit if folks feel strongly about it.