DRAFT: RAA229620A phase check and open pin support #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparing for adding more variants to SupportedDevices. The list of SupportedDevices was present, explicitly or implicitly, in several places in the code: - The enum definition itself - A list of strings used to filter device names - A set of match statements used to convert those strings into variants of the enum - Error messages listing support device types, which hardcoded the variant names. - A Display impl that repeated the names. This was noisy and potentially error-prone. I have simplified it by applying the `strum` crate to derive traits for the SupportedDevice macro: - `FromStr` (derived by EnumString) eliminates all handrolled parsing and match code - `VariantNames` (derived by EnumVariantNames) allows the error messages to list expected names without hardcoding them - `Display` can now be derived automatically. I chose `strum` because of its option to make string comparisons case-insensitive, which neatly covers this command's use case of converting lowercase manifest device names into uppercase enum variants.
This contains a bunch of assumptions (marked with TODOs) and may not work. We are reaching out to Renesas for clarifications.
cbiffle
force-pushed
the
cbiffle/cosmo-rendmp
branch
from
13112e2 to
e3c0a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably doesn't work yet, we're waiting for confirmation from Renesas.