Have qspi take a slot argument #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hubris QSPI APIs target either flash slot 0 or flash slot 1. Currently `humility qspi` uses the version of the API that targets the active slot. This can be confusing if another command was run targeting the inactive slot. Have `humility qspi` take a slot argument to change the slot before running any commands.
mkeeter
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hubris QSPI APIs target either flash slot 0 or flash slot 1. Currently
humility qspiuses the version of the API that targets the active slot. This can be confusing if another command was run targeting the inactive slot. Havehumility qspitake a slot argument to change the slot before running any commands.