Respect probe selection in humility debugmailbox
#578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbott
force-pushed
the
fix_debugmailbox_probe
branch
from
0af385e to
a98ea0f
Compare
To access the debugmailbox, we have to jump through some extra hoops to get the raw debug probe. We should still respect the probe selected via the command line or `HUMILITY_PROBE` environment variable. If no probe is specified we go with the existing behavior of chosing the first probe, otherwise the probe must be specified in `vid:pid:serial` format.
labbott
force-pushed
the
fix_debugmailbox_probe
branch
from
a98ea0f to
009905b
Compare
mkeeter
reviewed
Oct 21, 2025
mkeeter
reviewed
Oct 21, 2025
mkeeter
approved these changes
Oct 21, 2025
Co-authored-by: Matt Keeter <matt@oxide.computer>
Co-authored-by: Matt Keeter <matt@oxide.computer>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To access the debugmailbox, we have to jump through some extra hoops to get the raw debug probe. We should still respect the probe selected via the command line or
HUMILITY_PROBEenvironment variable. If no probe is specified we go with the existing behavior of chosing the first probe, otherwise the probe must be specified invid:pid:serialformat.