Conversation
Adds a build script for pulling clickhouse from source, applying patches, and actually building the source as we need it. This pulls version 21.5 of the server, but from an unnamed commit -- this was just the tip of the main branch when the patches were developed.
Contributor
Author
|
This packages the server binary, config files, and an SMF manifest into the tarball. The config files and SMF manifests have hard-coded paths in them, so everything expects to be unpacked into a directory |
- Moves most patches upstream in various places - Moves remaining patches and renames them for clarity - Build script pulls from our own fork for control - Adds README with some notes
- Updates build.sh script for better platform detection, patch application, tarball file inclusion - Moves patches to common and platform-specific directories - Updates SMF manifest for ClickHouse v21.7
Most configuration file paths now use /tmp, instead of /var, which may not exist or not be world-writable. This also updates the embedded.xml file to use /tmp. ClickHouse has a complex process for determining file paths, loading configuration from the embedded files, on-disk files, and the command-line. It mostly respects these, but starts by writing out the processed configuration file to the location in the embedded XML file, regardless of any other paths. This was previously CWD, which meant users might have extra config files laying around after ClickHouse exits. This puts those in /tmp as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a build script for pulling clickhouse from source, applying
patches, and actually building the source as we need it. This pulls
version 21.5 of the server, but from an unnamed commit -- this was just
the tip of the main branch when the patches were developed.