[full-ci][tests-only] test: convert denySpaceAccess.feature test to playwright #13467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
nirajacharya2
force-pushed
the
denySpaceAccess-2-pw
branch
from
36e961a to
262bfe1
Compare
nirajacharya2
requested review from
Ashim-Stha,
PrajwolAmatya,
Salipa-Gurung,
nabim777 and
saw-jan
Contributor
|
We need to delete |
saw-jan
reviewed
Jan 22, 2026
nirajacharya2
force-pushed
the
denySpaceAccess-2-pw
branch
from
262bfe1 to
051127c
Compare
|
saw-jan
reviewed
Jan 22, 2026
| resource: 'space-folder' | ||
| }) | ||
| expect( | ||
| await ui.resourceExists({ |
Member
There was a problem hiding this comment.
we should use this like ui.resourceShouldExist(...) and do assertion inside that function and not here, but that is for next improvement PR.
saw-jan
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
convert denySpaceAccess.feature test to playwright test
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: