[FIX] Keep Members entry visible; restrict member list by read permission (#4782)

[corevibe555]

Problem

Users without the libre.graph/driveItem/permissions/read permission had the Members action hidden from the space menu.
However, that screen also contains the Space Public Links (Permalink) section, which became inaccessible to these users.

Solution

• Always include Members in the filtered space menu options.
• In SpaceMembersFragment, treat the read permission as controlling only the members list (i.e., the RecyclerView visibility and adapter data).
  The Share via link section remains unaffected.

Issue

#4782

[CLAassistant]

All committers have signed the CLA.

[jesmrec]

Thanks for the contribution @corevibe555 . I'll give you some tips that you will also find in our CONTRIBUTING file:

• For the branch names, we use underscore _ to separate the chunks, like corevibe555:fix/apply_read_permission_to_the_list_of_members. Don't worry for that in the current PR, but please take in account for future contributions 😉. We'd appreciate that.

• In terms of CHANGELOG, we use calens to keep our changelog updated. The only task you have to do is adding an small file to our unreleased folder, which name is the PR number. There, you'll find some examples. As a guide, here you have the TEMPLATE. Don't forget to use the present perfect passive tense!! let us know about any question about this.

• I see two different commiters (root and corevibe555). In order to be able to merge the PR, every commiter must sign the CLA. As you can see in the CLAassistant message, just one is signed, so the CI system ⬇️ is waiting for it (required).

• About CI, we use Detekt as static code analyzer. Detekt is marking the PR with a red ❌ (check it below ⬇️ ), because one of the methods you changed exceedes the maximum number of lines. Take a look into it and let us know!

• As information, every PR has to pass two different stages: a code review that uses to be done by @joragua , and a QA-testing phase, that i will do once code review is approved. During these phases, we can suggest or ask you for changes (always open to discussion). When both CR and QA passes, the PR is merged. Also interesting to know: our branch update method is rebasing, not merging.

Any question about the process, @joragua or myself will be happy to help you!! Don't hesitate to ask!! 😄

[corevibe555]

@jesmrec Thanks for your comment.
I am working on the feedback.

[jesmrec]

@jesmrec Thanks for your kind comment.
I am working on these feedback.
As a first time contributor, I will keep in mind for any future contributions.

cool! let us know if you need some help 🚀

[jesmrec]

Thanks @corevibe555 for the quick response. New iteration is much better, but still some tiny details to take care of:

• About the calens file, we might not need a calens entry for the current PR, since it's not released yet. Just add the links to the following calens file: https://github.com/owncloud/android/blob/master/changelog/unreleased/4728, that complies all the features and fixes related with the Members option. Sorry, i did notice that first, and thanks to @joragua for the tip.

• We also use to reduce the number of commits. For example, this commit could be saved by removing the comment lines from the commit ahead with an interactive rebase (let us know if you need help)

• I'd mark the detekt commit as refactor instead of a fix, it fits better.

Summing up, this could be the better approach:

• fix: show members menu without permissions/read -> including your fix candidate
• chore: add changelog -> add links to 4728 calens file
• refactor: resolve Detekt issue -> with the Detekt stuff

with this, we could move to code review.

[corevibe555]

Thanks for the feedback, I've updated the PR.

[jesmrec]

Moving to CR. As soon as we are available, we'll review and give you feedback. Thanks!