Conversation
There was a problem hiding this comment.
Pull request overview
This PR vendors libinjection as a Git submodule (under apache2/others/libinjection) and updates build/test tooling and ModSecurity operators to use the newer libinjection sources/API.
Changes:
- Add
libinjectionas a submodule and update CI to checkout submodules. - Update Automake/CMake build inputs to compile libinjection sources from the submodule path.
- Update
@detectSQLi/@detectXSSoperator logic to handleinjection_result_treturn codes (TRUE/FALSE/ERROR).
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tests/Makefile.am |
Build test binary against libinjection sources from the new submodule location. |
standalone/Makefile.am |
Build standalone library against libinjection sources from the new submodule location. |
iis/CMakeLists.txt |
Build IIS target against libinjection sources from the new submodule location. |
apache2/re_operators.c |
Switch operators to injection_result_t results and add ERROR handling/messages. |
apache2/Makefile.am |
Build Apache module against libinjection sources from the new submodule location. |
.gitmodules |
Add apache2/others/libinjection submodule definition. |
.github/workflows/test-ci-windows.yml |
Ensure Windows CI checks out submodules. |
.github/workflows/ci.yml |
Ensure Linux CI checks out submodules (and adds git where needed). |
apache2/libinjection/* (deleted) |
Remove the previously vendored in-tree libinjection sources/headers/license file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 19 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
what
This PR adds libinjection as a submodule. From now everyone can use the last release - or any other state - of
libinjection, like in case of libmodsecurity3.why
The current tree has a very old version of libinjection. There were couple of changes which improved the library's quality and libinjection's efficiency, for eg. xss detection
references
#3528