-
Notifications
You must be signed in to change notification settings - Fork 1.7k
V3/do not add newline to test body lines #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3/master
Are you sure you want to change the base?
V3/do not add newline to test body lines #3486
Conversation
This is needed to test edge cases like a body missing the final newline, for example: [ "a\r\n", "b\r" ] And it is clearer than to add implicit newline to each line except the final line.
when UPDATE_CONTENT_LENGTH env var is set
by running the following command: ``` (cd test; ./regression_tests format) ```
by running the following command: ``` (cd test; UPDATE_CONTENT_LENGTH=1 ./regression_tests format) ```
8fefe12 to
9b49187
Compare
|
I found JSON was corrupted since some of http_version was empty. I fixed it and force pushed. |
|
I fixed tests at aefd4a4 and now all tests pass again. |
|
Hi @hnakamur, thank you for this improved PR. Unfortunately there are two warnings from cppcheck: Also, SonarCloud reported a few new issues (some of them are same as As I mentioned previously, I don't expect to fix all Sonar issues. If the Thank you again. |
|



what
formatsubcommand toregression_testscommand.Content-Lengthheader by running(cd test; UPDATE_CONTENT_LENGTH=1 ./regression_tests format)why
references