Stream database dump exports#240
Open
akmittal006 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
/claim #59
Purpose
Stream SQL database dump responses so large exports no longer build a single in-memory SQL string before returning a file. This directly addresses the current /export/dump memory pressure path while keeping the response-download behavior intact for bounded requests.
Tasks
Verify
Before
/export/dump accumulated the full dump in memory by appending table DDL and every row INSERT to one string before wrapping it in a Blob. Large databases could exhaust memory or block too long before a response could be streamed back.
After
/export/dump returns a ReadableStream, writes the SQLite header and table schema incrementally, and fetches row INSERTs in bounded batches with short yields between full batches.