Fix docker compose postgres volume path#583
Open
MaximilianHausen wants to merge 1 commit intooss-apps:mainfrom
Open
Fix docker compose postgres volume path#583MaximilianHausen wants to merge 1 commit intooss-apps:mainfrom
MaximilianHausen wants to merge 1 commit intooss-apps:mainfrom
Conversation
Partial revert of ac586b1. The compose files previously used the mountpoint for postgres 18 containers (/var/lib/postgresql) on a postgres 17 container. Since the actual mountpoint, defined in the image as /var/lib/postgresql/data, is still free, a new unnamed volume was created for each container, resetting the database with every `docker compose down`. Also locks the container version in the dev setup because the path will need to be changed back once the custom image is updated to postgres 18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partial revert of #488.
Relevant upstream pr: docker-library/postgres#1259
The current compose files use the mountpoint for postgres 18 containers (/var/lib/postgresql) on a postgres 17 container. Since the actual mountpoint, defined in the image as /var/lib/postgresql/data, is still free, a new unnamed volume is created for each container, resetting the database with every
docker compose down.This pr also locks the image version in the dev setup because this path is not compatible with postgres 18 containers and has to be changed back once the modified image is updated.
Updating the ossapps/postgres image and the reference in docker/prod/compose.yml to postgres 18 would also fix the issue.
Demo
Relevant output from
docker container inspect:Checklist
CONTRIBUTING.mdin its entirety